feat(deploy-component): add install_allow_scripts flag - #636
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
…deploy_component) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Patch cherry-pick: conflictCherry-pick onto The conflict markers are committed on branch |
dawsontoth
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_allow_scripts(boolean, optional) to bothdeploy_componentandadd_componentoperationsoperationsValidation.jsdeploy_component: persisted to application config asinstall.allowInstallScripts(picked up on restart via the existing config-load path inApplication.ts:540)Applicationconstructor so the immediate install honors itPurpose
Application.tsalready supportsinstall.allowInstallScriptsto toggle--ignore-scriptson the underlying npm/yarn/pnpm call, but there was no way to set this flag via the operation API. This wires the missing connection for both operations that perform installs.Default behaviour unchanged
When omitted,
allowInstallScriptsisundefined→ falsy →--ignore-scriptsis used, which was already the default.Notes
add_componentdoes not write to the root config (it clones a template directly), so only theApplicationconstructor is updated there — no config-persistence block.install_commandusers are unaffected; the flag only controls the default npm/yarn/pnpm invocation path.add_componentgap was flagged by Gemini and addressed in a follow-up commit.Generated by Claude (agent) — @kris please review